Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group patches to phishing warning page under the same minor version #81

Open
NicholasEllul opened this issue Mar 1, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@NicholasEllul
Copy link
Contributor

NicholasEllul commented Mar 1, 2023

As Lego noted in #79, we lack the ability to perform on the fly patch updates to the phishing warning page used by the MetaMask extension. This is due to the fact that we pin MetaMask to point to a specific x.y.z version of the phishing warning page. The only way we change this now is through updating the phishing warning page package used by MetaMask.

However, if we begin to make phishing warning page releases exist under a minor version granularity (ex: v1.2.4 publishes to metamask.github.io/phishing-warning/v1.2), we can automatically have updates stream live to all MetaMask extension users who have their update configured to v1.2.

An argument could be made to extend this to major version so that all non-breaking changes can be propagated automatically

@NicholasEllul NicholasEllul added the enhancement New feature or request label Mar 1, 2023
@NicholasEllul NicholasEllul self-assigned this May 15, 2023
@NicholasEllul
Copy link
Contributor Author

Could also be scoped under major versions v1 v2 etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant