From 8587db151da96f2643881b0eecd69f5475ce9f2d Mon Sep 17 00:00:00 2001 From: legobt <6wbvkn0j@anonaddy.me> Date: Tue, 5 Sep 2023 21:43:35 +0000 Subject: [PATCH] BREAKING: Increase minimum Node.js version to 16; recommended to 18 --- .github/workflows/build-test.yml | 2 +- .nvmrc | 2 +- README.md | 2 +- package.json | 4 ++-- yarn.lock | 8 ++++---- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 0c86368..0a1f0ef 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-20.04 strategy: matrix: - node-version: [12.x, 14.x, 16.x] + node-version: [16.x, 18.x, 20.x] steps: - uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} diff --git a/.nvmrc b/.nvmrc index dae199a..3f430af 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v12 +v18 diff --git a/README.md b/README.md index d654bdb..5b2d246 100644 --- a/README.md +++ b/README.md @@ -27,7 +27,7 @@ streamB.pipe(evilAiBrain).pipe(streamB); ### Setup -- Install [Node.js](https://nodejs.org) version 12 +- Install [Node.js](https://nodejs.org) version 18 - If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm use` will automatically choose the right node version for you. - Install [Yarn v1](https://yarnpkg.com/en/docs/install) - Run `yarn setup` to install dependencies and run any requried post-install scripts diff --git a/package.json b/package.json index 231cf60..3fb91d4 100644 --- a/package.json +++ b/package.json @@ -9,7 +9,7 @@ "url": "https://github.com/MetaMask/object-multiplex.git" }, "engines": { - "node": ">=12.0.0" + "node": "^16.20 || ^18.16 || >=20" }, "files": [ "dist/" @@ -39,7 +39,7 @@ "@metamask/eslint-config-nodejs": "^6.0.0", "@metamask/eslint-config-typescript": "^6.0.0", "@types/end-of-stream": "^1.4.0", - "@types/node": "^14.14.9", + "@types/node": "^16", "@types/once": "^1.4.0", "@types/readable-stream": "^2.3.9", "@typescript-eslint/eslint-plugin": "^4.26.0", diff --git a/yarn.lock b/yarn.lock index b5829f9..5616dc1 100644 --- a/yarn.lock +++ b/yarn.lock @@ -147,10 +147,10 @@ resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.10.tgz#5958a82e41863cfc71f2307b3748e3491ba03785" integrity sha512-J32dgx2hw8vXrSbu4ZlVhn1Nm3GbeCFNw2FWL8S5QKucHGY0cyNwjdQdO+KMBZ4wpmC7KhLCiNsdk1RFRIYUQQ== -"@types/node@^14.14.9": - version "14.14.9" - resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.9.tgz#04afc9a25c6ff93da14deabd65dc44485b53c8d6" - integrity sha512-JsoLXFppG62tWTklIoO4knA+oDTYsmqWxHRvd4lpmfQRNhX6osheUOWETP2jMoV/2bEHuMra8Pp3Dmo/stBFcw== +"@types/node@^16": + version "16.18.48" + resolved "https://registry.yarnpkg.com/@types/node/-/node-16.18.48.tgz#3bc872236cdb31cb51024d8875d655e25db489a4" + integrity sha512-mlaecDKQ7rIZrYD7iiKNdzFb6e/qD5I9U1rAhq+Fd+DWvYVs+G2kv74UFHmSOlg5+i/vF3XxuR522V4u8BqO+Q== "@types/once@^1.4.0": version "1.4.0"