-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump @metamask/signature-controller
to ^22.0.0
#12474
chore: bump @metamask/signature-controller
to ^22.0.0
#12474
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: cc9322a Note
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Similar to the preferences controller update PR, this introduces a new peer dependency warning but doesn't introduce any new risks.
The warning is due to this version requiring v18 of keyring-controller, but mobile uses v17. The only difference in v18 is the removal of addNewAccountWithoutUpdate, which the preferences controller does not use.
The warning will go away with #12339
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR bumps
@metamask/signature-controller
to^22.0.0
Related issues
Fixes: #12307
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist