-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Implement new token list endpoint #6030
Comments
Suggestion: If there are breaking changes, split this ticket into 2 sub-tickets:
|
Created an epic for it (The epic associated with this ticket), kept this issue to track the implementation of new token list endpoint |
Hi @Gudahtt , we came across that ticket during Mobile sprint planning session today and were wondering whether SL teams could help on this ticket? Would it make sense in terms of scope and does the SL team have bandwidth for it? |
@gauthierpetetin Sure, no problem. I have added this to our backlog. |
Thanks a lot @Gudahtt ! |
Closing in favor of MetaMask/core#1519 which covers this same task |
Reopening issue so that we can put it on our board. |
I don't think this is an issue now. We've been using TokenListController from |
Description
This issue aims to implement the new token list endpoint.
The details of the endpoint can be found here.
Technical Details
Core repo changes:
getTokensURL
for the new endpointfilteredTokenList
to line 297 (this logic is on the api side now)Mobile changes:
Suggestion (We should aim to instead of creating a patch, update the assets-controller version instead):
Acceptance Criteria
Scenario: Token list on token detection feature
Scenario: Token list on token detection feature
References
The text was updated successfully, but these errors were encountered: