Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Implement new token list endpoint #6030

Closed
tommasini opened this issue Mar 23, 2023 · 9 comments
Closed

Core: Implement new token list endpoint #6030

tommasini opened this issue Mar 23, 2023 · 9 comments

Comments

@tommasini
Copy link
Contributor

tommasini commented Mar 23, 2023

Description

This issue aims to implement the new token list endpoint.
The details of the endpoint can be found here.

Technical Details

Core repo changes:

  • On token-service.ts changegetTokensURL for the new endpoint
  • On TokenListController.ts delete line 280 filteredTokenList to line 297 (this logic is on the api side now)
  • Do the necessary changes for this to work as with the previous endpoint

Mobile changes:
Suggestion (We should aim to instead of creating a patch, update the assets-controller version instead):

  • Create a patch with the changes above

Acceptance Criteria

  • The token list should be working the exact same way as it was.

Scenario: Token list on token detection feature

  • GIVEN a user is in wallet view
  • WHEN a user does have tokens to import
  • THEN it should show those tokens (Token detection feature)

Scenario: Token list on token detection feature

  • GIVEN a user is in wallet view
  • WHEN a user tries to import a token manually
  • THEN it should be able to find the token by the name

References

  • References go here.
  • Issue numbers. Links.
  • Slack threads.
  • Etc.
@gauthierpetetin
Copy link
Contributor

More info about the new endpoint:

Screenshot 2023-03-30 at 14 37 48

@gauthierpetetin
Copy link
Contributor

Suggestion:

If there are breaking changes, split this ticket into 2 sub-tickets:

  • one with the update of the package
  • one with the integration of the new token endpoint

@tommasini
Copy link
Contributor Author

Created an epic for it (The epic associated with this ticket), kept this issue to track the implementation of new token list endpoint

@tommasini tommasini changed the title Implement new token list endpoint Core: Implement new token list endpoint Apr 3, 2023
@gauthierpetetin
Copy link
Contributor

Hi @Gudahtt , we came across that ticket during Mobile sprint planning session today and were wondering whether SL teams could help on this ticket? Would it make sense in terms of scope and does the SL team have bandwidth for it?
cc @Cal-L @sethkfman @hesterbruikman

@Gudahtt
Copy link
Member

Gudahtt commented Apr 12, 2023

@gauthierpetetin Sure, no problem. I have added this to our backlog.

@gauthierpetetin
Copy link
Contributor

Thanks a lot @Gudahtt !

@Gudahtt
Copy link
Member

Gudahtt commented Jul 20, 2023

Closing in favor of MetaMask/core#1519 which covers this same task

@mcmire
Copy link
Contributor

mcmire commented Nov 16, 2023

Reopening issue so that we can put it on our board.

@mcmire
Copy link
Contributor

mcmire commented Oct 25, 2024

I don't think this is an issue now. We've been using TokenListController from core for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants