Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Update What's New Modal #4479

Closed
Cal-L opened this issue Jun 8, 2022 · 2 comments
Closed

[5.3] Update What's New Modal #4479

Cal-L opened this issue Jun 8, 2022 · 2 comments
Assignees
Labels
release-5.3.0 Issue or pull request that will be included in release 5.3.0

Comments

@Cal-L
Copy link
Contributor

Cal-L commented Jun 8, 2022

Description

Update What's New Modal to use templating system

Technical Details

  • Update WhatsNewModal/index.js to parse and render data from whatsNewList.js
  • Update whatsNewList.js with template system
- Slides utilizes a templating system in the form of a 2D array, which is eventually rendered within app/components/UI/WhatsNewModal/index.js.
- The root layer determines the number of slides. Ex. To display 3 slides, the root layer should contain 3 arrays.
- The inner layer determines the content that will be rendered within each slide.
- The slide content takes the form of union types, where the possible types are `image`, `title`, `description`, or `button`.
- Both slide count and slide content will be rendered in the same order as the data set.

Acceptance Criteria

  • Template system should support any number of slides
  • It should also support any order of the union types

References

@Cal-L Cal-L self-assigned this Jun 8, 2022
@wachunei
Copy link
Member

wachunei commented Jun 8, 2022

typescript? 👀

@Cal-L
Copy link
Contributor Author

Cal-L commented Jun 13, 2022

Included in #4484

@Cal-L Cal-L closed this as completed Jun 13, 2022
@mobularay mobularay added the release-5.3.0 Issue or pull request that will be included in release 5.3.0 label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-5.3.0 Issue or pull request that will be included in release 5.3.0
Projects
None yet
Development

No branches or pull requests

3 participants