Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transiction send error "invalid sender" when sending over private Ethereum network #1832

Closed
pavelkrolevets opened this issue Sep 15, 2020 · 6 comments
Labels
community Issues or PRs opened by the MM community stale Issues that have not had activity in the last 90 days type-bug Something isn't working

Comments

@pavelkrolevets
Copy link

Describe the bug

Mobile Metamask fail to send ASK over https:// endpoint of another proof-of-authority network. Error - invalid sender. This indicates that the signature is wrong. It seems the signing function cant generate right sing when chainID !== networkID for private networks. I also tested when chainID == networkID on my local network on

Network Name: ASK Mainnet
New RPC URL: https://blockchain-api-mainnet.permission.io/rpc
ChainID: 222
Symbol: ASK
Block Explorer URL: https://explorer.permission.io/

I am able to receive ASK in the iOS and Android mobile apps. But when I try to send from iOS or Android to another Metamask wallet I receive the error: "Transaction Error - Object [Object]" with no additional information about why it failed.

Screenshots
image
image

To Reproduce

  1. Add network ASK mainnet in the Mobile Metamask with parameters
    Network Name: ASK Mainnet
    New RPC URL: https://blockchain-api-mainnet.permission.io/rpc
    ChainID: 222
    Symbol: ASK
    Block Explorer URL: https://explorer.permission.io/
  2. Send native tokens to another account.

Another way:

  1. Run local private network with chainID !== networkID
  2. Send tokens to another account

Expected behavior
Transaction should be accepted to the network, but get error - invalid sender. Which indicates that the signature is wrong despite that chainID is provided (222), but networkID is different (2221).

Smartphone (please complete the following information):

  • Device: iPhone 6 Plus
  • OS: iOS 13.6
  • App Version v1.0.1(522)

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@pavelkrolevets pavelkrolevets added the type-bug Something isn't working label Sep 15, 2020
@pavelkrolevets
Copy link
Author

This maybe related #1820

@evanliuchina
Copy link

Got exactly the same problem. Did you find any way to work around @pavelkrolevets ?

@iquidus
Copy link

iquidus commented Jan 13, 2021

bump.

This impacts all networks in which networkId and chainId do not match. Not just private nets, but live public nets also (e.g ethereum classic & ubiq). Signing transactions with networkId is invalid behavior (not to spec), producing invalid transactions (unless the Ids happen to match).

Users can receive funds to metamask mobile on these networks but only to have it stranded as they can't produce valid transactions. Requiring them to import recovery phrase into an alternative wallet to recover said funds.

@iquidus
Copy link

iquidus commented Jan 13, 2021

First time looking at the mobile code but here is one such occurrence (and possibly the main culprit?): https://github.com/MetaMask/metamask-mobile/blob/develop/app/components/UI/PaymentRequest/index.js#L292

@jyap808
Copy link

jyap808 commented Jan 26, 2021

Please back port the fix from the main Metamask browser extension.
Network ID <> Chain ID

Thanks

@gantunesr gantunesr added the community Issues or PRs opened by the MM community label Sep 14, 2021
@sethkfman sethkfman added the stale Issues that have not had activity in the last 90 days label Jun 9, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 7 days with no activity. If you feel this was closed in error please reopen and provide evidence on the current production app. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues or PRs opened by the MM community stale Issues that have not had activity in the last 90 days type-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants