Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Send token deeplink is adding token to wallet account when Confirm is cancelled, app crash on Token Details #11984

Open
chrisleewilcox opened this issue Oct 23, 2024 · 0 comments
Labels
regression-RC-7.34.0 Regression bug that was found in release candidate (RC) for release 7.34.0 release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-sdk SDK team type-bug Something isn't working

Comments

@chrisleewilcox
Copy link
Contributor

chrisleewilcox commented Oct 23, 2024

Describe the bug

After tapping a send token deeplink and cancelling the send on Confirm screen the token to send is added to wallet account and displayed on token list. Tokens that are auto-added by a deeplink will crash app on Token Details view, even if the Token was already imported before tapping deeplink.

Send token deeplink: https://metamask.app.link/send/0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48@1/transfer?address=0x2990079bcdEe240329a520d2444386FC119da21a&uint256=2.5e7

Expected behavior

Tokens should not be auto-added if send was cancelled.

Screenshots/Recordings

Screen.Recording.2024-10-23.at.1.11.13.PM.mov

Steps to reproduce

GIVEN I tapped on a send token deeplink
AND wallet account does not have send token imported
AND send token Confirm screen is displayed
WHEN I tap 'Cancel'
THEN Confirm screen is dismissed
AND no transaction was executed
AND send token is not displayed on Token List (FAILED: token is added)

Error messages or log output

No response

Detection stage

During release testing

Version

7.34.0

Build type

None

Device

Any

Operating system

iOS, Android

Additional context

No response

Severity

No response

@chrisleewilcox chrisleewilcox added type-bug Something isn't working team-sdk SDK team release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing labels Oct 23, 2024
@metamaskbot metamaskbot added the regression-RC-7.34.0 Regression bug that was found in release candidate (RC) for release 7.34.0 label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-7.34.0 Regression bug that was found in release candidate (RC) for release 7.34.0 release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-sdk SDK team type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

2 participants