-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix signTypedData_v4 chainId validation #9552
Conversation
Builds ready [876ce04]
Page Load Metrics (433 ± 52 ms)
|
2905bb0
to
876ce04
Compare
Builds ready [876ce04]
Page Load Metrics (377 ± 38 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, glad we're finally using the semantic meaning of chainId instead of networkId's "usually the same" behavior.
876ce04
to
06c0da6
Compare
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [06c0da6]
Page Load Metrics (443 ± 49 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We were checking the
chainId
passed withsignTypedData_v4
requests againstNetworkController.network
, which is wrong. This PR ensures that we check it against the storedchainId
.Fixes #8385