fix (cherry-pick): increase signing or submitting alert severity to danger (#29140) #29192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> This PR addresses an issue where users are currently able to submit multiple Smart Transaction (STX) requests while one is still pending in the redesigned confirmation flow. This functionality is already correctly implemented in the legacy confirmation flow, and the redesigned flow is updated to match this behaviour. **Changes Introduced:** - Updates the alert text to match the copy used in the legacy confirmation flow. - Increases the severity of the alert from `Warning` to `Danger`. - Ensures that dangerous banner alerts block the confirm button to avoid user actions until resolved. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/29140?quickstart=1) Fixes: #29138 1. Submit a STX 2. Trigger a new transaction [wait_submitted_tx.webm](https://github.com/user-attachments/assets/0eff285e-46b1-409f-8041-4c99fef89839) <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vinistevam
commented
Dec 13, 2024
| @@ -411,4 +411,73 @@ describe('Contract Interaction Confirmation Alerts', () => { | |||
| await screen.findByTestId('alert-modal-action-showGasFeeModal'), | |||
| ).toHaveTextContent('Update gas options'); | |||
| }); | |||
|
|
|||
| it('displays the alert for signing and submitting alerts', async () => { | |||
There was a problem hiding this comment.
The difference between the lines changed is because this test only exists in the main branch.
pedronfigueiredo
approved these changes
Dec 13, 2024
OGPoyraz
approved these changes
Dec 13, 2024
Builds ready [f56ab57]
Page Load Metrics (1887 ± 142 ms)
|
](https://codespaces.new/MetaMask/metamask-extension/pull/29140?quickstart=1){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick of #29140 for release
12.9.2.Related issues
Fixes: #29138
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist