-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove old phishfort list from clients #27743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
AugmentedMode
changed the title
migrate: remove old phishfort list from clients
fix: remove old phishfort list from clients
Oct 9, 2024
Gudahtt
reviewed
Oct 9, 2024
Co-authored-by: Mark Stacey <[email protected]>
Gudahtt
reviewed
Oct 9, 2024
Gudahtt
reviewed
Oct 9, 2024
Co-authored-by: Mark Stacey <[email protected]>
Gudahtt
reviewed
Oct 9, 2024
Co-authored-by: Mark Stacey <[email protected]>
Gudahtt
previously approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cryptotavares
previously approved these changes
Oct 9, 2024
AugmentedMode
dismissed stale reviews from cryptotavares and Gudahtt
via
October 9, 2024 21:48
8d84423
cryptotavares
previously approved these changes
Oct 9, 2024
mindofmar
previously approved these changes
Oct 9, 2024
AugmentedMode
dismissed stale reviews from mindofmar and cryptotavares
via
October 9, 2024 22:14
dfc3964
cryptotavares
approved these changes
Oct 9, 2024
Quality Gate passedIssues Measures |
mindofmar
approved these changes
Oct 9, 2024
Builds ready [dfc3964]
Page Load Metrics (1847 ± 101 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 9, 2024
metamaskbot
added
the
release-12.7.0
Issue or pull request that will be included in release 12.7.0
label
Oct 9, 2024
gauthierpetetin
added
release-12.6.0
Issue or pull request that will be included in release 12.6.0
and removed
release-12.7.0
Issue or pull request that will be included in release 12.7.0
labels
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-product-safety
Push issues to Product Safety team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that prevented users from receiving the updated hotlist from ETH Phishing Detect. While the client still fetched the hotlist, the
PhishingDetector
was unable to update with the new URLs included in the hotlist.Related issues
Fixes: #27737
Pre-merge author checklist
Pre-merge reviewer checklist