Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove old phishfort list from clients #27743

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

AugmentedMode
Copy link
Contributor

@AugmentedMode AugmentedMode commented Oct 9, 2024

Description

This PR fixes an issue that prevented users from receiving the updated hotlist from ETH Phishing Detect. While the client still fetched the hotlist, the PhishingDetector was unable to update with the new URLs included in the hotlist.

Open in GitHub Codespaces

Related issues

Fixes: #27737

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@AugmentedMode AugmentedMode requested a review from a team as a code owner October 9, 2024 20:54
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptotavares cryptotavares added the team-product-safety Push issues to Product Safety team label Oct 9, 2024
@AugmentedMode AugmentedMode changed the title migrate: remove old phishfort list from clients fix: remove old phishfort list from clients Oct 9, 2024
@AugmentedMode AugmentedMode self-assigned this Oct 9, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 9, 2024
Gudahtt
Gudahtt previously approved these changes Oct 9, 2024
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cryptotavares
cryptotavares previously approved these changes Oct 9, 2024
@AugmentedMode AugmentedMode dismissed stale reviews from cryptotavares and Gudahtt via 8d84423 October 9, 2024 21:48
cryptotavares
cryptotavares previously approved these changes Oct 9, 2024
mindofmar
mindofmar previously approved these changes Oct 9, 2024
@AugmentedMode AugmentedMode disabled auto-merge October 9, 2024 22:13
@AugmentedMode AugmentedMode dismissed stale reviews from mindofmar and cryptotavares via dfc3964 October 9, 2024 22:14
Copy link

sonarcloud bot commented Oct 9, 2024

@AugmentedMode AugmentedMode added this pull request to the merge queue Oct 9, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [dfc3964]
Page Load Metrics (1847 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16092347185219895
domContentLoaded15462290180418690
load155023491847210101
domInteractive166639136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.05 KiB (0.03%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 9, 2024
@cryptotavares cryptotavares added this pull request to the merge queue Oct 9, 2024
Merged via the queue into develop with commit 50dceb5 Oct 9, 2024
79 checks passed
@cryptotavares cryptotavares deleted the migrate/remove-phishfort-list branch October 9, 2024 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 9, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-product-safety Push issues to Product Safety team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Invalid config parameter: 'name'
6 participants