Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid jarring transition between popup-init and popup by fading in the app screen #26599

Closed
wants to merge 1 commit into from

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Aug 21, 2024

Depends on #26555

See frame-by-frame part of the video in the description of #26555 for an example of what this is trying to "solve".

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Aug 21, 2024

@davidmurdoch
Copy link
Contributor Author

We are going to inline the loading screen into popup-init.html, so this transition is no longer required.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant