-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump accounts controller and migration to fix undefined selectedAccount #26573
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected]), npm/@metamask/[email protected]) |
@metamaskbot update-policies |
Policies updated |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26573 +/- ##
===========================================
+ Coverage 70.02% 70.05% +0.02%
===========================================
Files 1406 1411 +5
Lines 49076 49219 +143
Branches 13725 13757 +32
===========================================
+ Hits 34364 34476 +112
- Misses 14712 14743 +31 ☔ View full report in Codecov by Sentry. |
Builds ready [7d5955c]
Page Load Metrics (76 ± 7 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like, left some minor comments
Quality Gate passedIssues Measures |
Builds ready [e6a2d32]
Page Load Metrics (82 ± 18 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
@@ -24,7 +25,7 @@ export const SnapAccountCard = ({ | |||
const account = mergedAccounts.find( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a note here as a TODO for us to remove the need of mergeAccounts
Description
This PR bumps the
AccountsController
and introduces a new migration. TheupdateAccounts
methods from theAccountsController
now checks if the selectedAccount is undefined and recovers from this. The migration updates the selectedAccount values that are not defined.Related issues
Fixes: #26377
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist