Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vertically align asset image #25988

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: vertically align asset image #25988

merged 1 commit into from
Jul 19, 2024

Conversation

BZahory
Copy link
Contributor

@BZahory BZahory commented Jul 19, 2024

Description

In #25470, the BadgeWrapper was implemented for the send flow. By default, this component uses inline-block styling and align-self: start to allow the network icon and asset icon to maintain alignment; this prevents the existing flex box styling from being applied.

This is mitigated by wrapping the component in a Box component.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to send page
  2. Select a recipient
  3. Ensure that the token image is vertically aligned
  4. Switch to an NFT
  5. Ensure that the NFT image is vertically aligned

Screenshots/Recordings

Before

Screenshot 2024-07-19 at 1 58 15 PM

After

Screenshot 2024-07-19 at 1 59 48 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@BZahory BZahory requested a review from a team as a code owner July 19, 2024 17:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@BZahory BZahory force-pushed the fix-asset-alignment branch from 229405f to c383fad Compare July 19, 2024 22:46
Copy link

sonarcloud bot commented Jul 19, 2024

@BZahory BZahory merged commit 62e01ef into develop Jul 19, 2024
78 of 79 checks passed
@BZahory BZahory deleted the fix-asset-alignment branch July 19, 2024 23:07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 19, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [c383fad]
Page Load Metrics (253 ± 257 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671951092713
domContentLoaded96031178
load422056253535257
domInteractive96031178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 56 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants