Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add name to scuttling exception list #25849

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix: add name to scuttling exception list #25849

merged 1 commit into from
Jul 16, 2024

Conversation

weizman
Copy link
Member

@weizman weizman commented Jul 16, 2024

No description provided.

@weizman weizman requested review from kumavis and a team as code owners July 16, 2024 09:22
@weizman weizman changed the title add name to scuttling exception list chore: add name to scuttling exception list Jul 16, 2024
@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template team-lavamoat labels Jul 16, 2024
Copy link

sonarcloud bot commented Jul 16, 2024

@weizman weizman changed the title chore: add name to scuttling exception list fix: add name to scuttling exception list Jul 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1fce95b]
Page Load Metrics (187 ± 243 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint693971156732
domContentLoaded1097322110
load432392187506243
domInteractive1097322110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.80%. Comparing base (b9de828) to head (1fce95b).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25849   +/-   ##
========================================
  Coverage    69.80%   69.80%           
========================================
  Files         1398     1398           
  Lines        49130    49130           
  Branches     13565    13565           
========================================
  Hits         34293    34293           
  Misses       14837    14837           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizman weizman merged commit 20f54db into develop Jul 16, 2024
91 of 93 checks passed
@weizman weizman deleted the weizman-add-name branch July 16, 2024 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-lavamoat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants