Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable hardware wallets for smart transactions in swaps #25742

Merged
merged 1 commit into from
Jul 19, 2024
Merged

feat: Enable hardware wallets for smart transactions in swaps #25742

merged 1 commit into from
Jul 19, 2024

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Jul 10, 2024

Description

This enables hardware wallets to be used with smart transactions in MetaMask swaps.

Updated event props for some events will be in an upcoming PR.

Related issues

Fixes:

Manual testing steps

  1. When a HW wallet is used in swaps on Ethereum Mainnet and smart transactions are enabled in settings, a transaction will be send as a smart transaction.
  2. For all other transaction types smart transactions will remain disabled for now if a user uses a HW wallet.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 added the team-transactions Transactions team label Jul 10, 2024
@dan437 dan437 requested a review from a team as a code owner July 10, 2024 14:43
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [e3e17ef]
Page Load Metrics (769 ± 501 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint741841332713
domContentLoaded107535178
load4526127691044501
domInteractive107535178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 137 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 765 Bytes (0.01%)

@dan437 dan437 force-pushed the stx-swaps-with-hw-wallet branch from e3e17ef to f23b6ea Compare July 11, 2024 11:55
@metamaskbot
Copy link
Collaborator

Builds ready [f23b6ea]
Page Load Metrics (237 ± 241 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint661711052713
domContentLoaded97330168
load401978237503241
domInteractive97330168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 137 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 765 Bytes (0.01%)

@dan437 dan437 force-pushed the stx-swaps-with-hw-wallet branch from f23b6ea to b5efe71 Compare July 11, 2024 12:25
@metamaskbot
Copy link
Collaborator

Builds ready [b5efe71]
Page Load Metrics (346 ± 302 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint664701228240
domContentLoaded9176373517
load522084346629302
domInteractive9176373517
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 137 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 765 Bytes (0.01%)

@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (43b8031) to head (7123888).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25742   +/-   ##
========================================
  Coverage    69.69%   69.69%           
========================================
  Files         1401     1401           
  Lines        49590    49592    +2     
  Branches     13707    13707           
========================================
+ Hits         34561    34563    +2     
  Misses       15029    15029

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan437 dan437 force-pushed the stx-swaps-with-hw-wallet branch from b5efe71 to 5e34786 Compare July 17, 2024 11:53
@metamaskbot
Copy link
Collaborator

Builds ready [5e34786]
Page Load Metrics (327 ± 298 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint691531022411
domContentLoaded95726126
load392096327620298
domInteractive95726126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 137 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 765 Bytes (0.01%)

@dan437 dan437 force-pushed the stx-swaps-with-hw-wallet branch 2 times, most recently from bc3783c to 9070eef Compare July 19, 2024 13:33
@dan437 dan437 force-pushed the stx-swaps-with-hw-wallet branch from 9070eef to e67ffdc Compare July 19, 2024 15:05
@dan437 dan437 force-pushed the stx-swaps-with-hw-wallet branch from e67ffdc to 7123888 Compare July 19, 2024 16:18
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [7123888]
Page Load Metrics (245 ± 229 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint783901358842
domContentLoaded97730188
load481678245477229
domInteractive97730178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 137 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 765 Bytes (0.01%)

@dan437 dan437 merged commit c9907bd into develop Jul 19, 2024
79 checks passed
@dan437 dan437 deleted the stx-swaps-with-hw-wallet branch July 19, 2024 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbrans dbrans dbrans approved these changes

@antonydenyer antonydenyer antonydenyer approved these changes

Assignees
No one assigned
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-transactions Transactions team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dan437 @metamaskbot @antonydenyer @dbrans