-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: define which keyring methods Portfolio can call #25633
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25633 +/- ##
========================================
Coverage 69.66% 69.66%
========================================
Files 1366 1366
Lines 48215 48215
Branches 13301 13301
========================================
Hits 33588 33588
Misses 14627 14627 ☔ View full report in Codecov by Sentry. |
Builds ready [1c3d3db]
Page Load Metrics (170 ± 182 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR adds a special case for Portfolio to allow it to call
submitRequest
andgetAccountsBalances
methods of a keyring Snap needed to support the BTC Snap, alongside other management methods (listAccounts
andgetAccount
).Related issues
Resolves: https://github.com/MetaMask/accounts-planning/issues/506
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist