Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define which keyring methods Portfolio can call #25633

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

danroc
Copy link
Contributor

@danroc danroc commented Jul 2, 2024

Description

This PR adds a special case for Portfolio to allow it to call submitRequest and getAccountsBalances methods of a keyring Snap needed to support the BTC Snap, alongside other management methods (listAccounts and getAccount).

Open in GitHub Codespaces

Related issues

Resolves: https://github.com/MetaMask/accounts-planning/issues/506

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@danroc danroc self-assigned this Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Jul 2, 2024

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.66%. Comparing base (7b69e3c) to head (1c3d3db).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25633   +/-   ##
========================================
  Coverage    69.66%   69.66%           
========================================
  Files         1366     1366           
  Lines        48215    48215           
  Branches     13301    13301           
========================================
  Hits         33588    33588           
  Misses       14627    14627           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [1c3d3db]
Page Load Metrics (170 ± 182 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint625401219847
domContentLoaded9242394924
load421779170379182
domInteractive9242394924
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 189 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@danroc danroc marked this pull request as ready for review July 2, 2024 16:22
@danroc danroc requested a review from a team as a code owner July 2, 2024 16:22
@ccharly ccharly merged commit da932ae into develop Jul 2, 2024
73 checks passed
@ccharly ccharly deleted the dr/portfolio-permissions branch July 2, 2024 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants