Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused fixtures and fix test name in smart swaps disabled spec #25616

Merged
merged 3 commits into from
Jul 2, 2024
Merged

fix: Remove unused fixtures and fix test name in smart swaps disabled spec #25616

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cedb87c
Remove unused fixtures and fix test name
plasmacorral Jul 1, 2024
8c0c337
Merge branch 'develop' into fix-e2e-test-name-smart-swap-disabled
plasmacorral Jul 2, 2024
52bc178
use import instead of require, and update test name
plasmacorral Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions test/e2e/accounts/smart-swap-disabled.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
import { title } from 'process';
import { Suite } from 'mocha';
import { withFixtures } from '../helpers';
import { withFixtures, defaultGanacheOptions } from '../helpers';
import { Driver } from '../webdriver/driver';
import {
accountSnapFixtures,
installSnapSimpleKeyring,
makeNewAccountAndSwitch,
} from './common';
import { installSnapSimpleKeyring, makeNewAccountAndSwitch } from './common';

// eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-var-requires
const FixtureBuilder = require('../fixture-builder');
plasmacorral marked this conversation as resolved.
Show resolved Hide resolved

describe('Smart Swaps', function (this: Suite) {
it('should be disabled for snap accounts', async function () {
await withFixtures(
accountSnapFixtures(title),
{
fixtures: new FixtureBuilder().build(),
ganacheOptions: defaultGanacheOptions,
title: this.test?.fullTitle(),
},
async ({ driver }: { driver: Driver }) => {
await installSnapSimpleKeyring(driver, false);
await makeNewAccountAndSwitch(driver);
Expand Down