feat: Remove blockaid migration BannerAlert

[pedronfigueiredo]

Description

On #23743, we introduced a BannerAlert that warns the user if they migrated from OpenSea to Blockaid security alerts and they are on a network that doesn't support them.

Since enough time has passed, this PR removes that logic

Related issues

#23743

Manual testing steps

See instructions on #23743

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[matthewwalsh0]

Just for audit sake, I agree that no migration is needed for this since it's a single boolean rather than a large array or object.

[pedronfigueiredo]

good shout, thanks for pointing it out

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@df81e73). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #25556   +/-   ##
==========================================
  Coverage           ?   69.60%           
==========================================
  Files              ?     1364           
  Lines              ?    48172           
  Branches           ?    13291           
==========================================
  Hits               ?    33526           
  Misses             ?    14646           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [5465fa6]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (487 ± 418 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	278	134	52	25
		domContentLoaded	10	110	42	23	11
		load	40	3392	487	872	418
		domInteractive	10	110	42	23	11

Bundle size diffs [🚀 Bundle size reduced!]

• background: -209 Bytes (-0.01%)
• ui: -3.17 KiB (-0.05%)
• common: -701 Bytes (-0.01%)