Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #25189 - Display network badge for send flow asset #25470

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Jun 21, 2024

Description

Adds the network badge for the chosen asset in the new Send flow

Open in GitHub Codespaces

Related issues

Fixes: #25189

Manual testing steps

  1. Go to Ethereum Mainnet
  2. Go to the Send flow
  3. See the chosen asset with Mainnet logo
  4. Change to Base network
  5. Go to Send flow
  6. See the chosen asset with the Base logo

Screenshots/Recordings

Before

338344947-c9a6eff0-74f1-4b8a-bca4-48a8325a14d8

After

SCR-20240621-jquj

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner June 21, 2024 15:38
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added team-wallet-ux release-12.0.0 Issue or pull request that will be included in release 12.0.0 regression-RC-12.0.0 team-assets and removed team-wallet-ux labels Jun 21, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.20%. Comparing base (dbdbaf1) to head (2de1709).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25470   +/-   ##
========================================
  Coverage    65.19%   65.20%           
========================================
  Files         1405     1405           
  Lines        55571    55575    +4     
  Branches     14592    14594    +2     
========================================
+ Hits         36229    36233    +4     
  Misses       19342    19342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [2de1709]
Page Load Metrics (53 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6912488136
domContentLoaded9151121
load40745394
domInteractive9151121
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 418 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@bergeron bergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested before and after

@darkwing darkwing merged commit e1cfecf into develop Jun 24, 2024
74 checks passed
@darkwing darkwing deleted the 25189-asset-picker-network branch June 24, 2024 20:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 24, 2024
@metamaskbot metamaskbot removed the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jul 9, 2024
@metamaskbot
Copy link
Collaborator

More than one release label on PR. Keeping the lowest one (release-12.0.0) on PR and removing other release labels (release-12.1.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression-RC-12.0.0 release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-assets team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Token icons are not displayed on send flow
5 participants