Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade dependency ws #25372

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix: upgrade dependency ws #25372

merged 2 commits into from
Jun 18, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jun 18, 2024

Description

  • fix: lockbump ws resolutions to latest
  • fix: force ws resolutions to latest within majors

Resolves:

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Jun 18, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat marked this pull request as ready for review June 18, 2024 03:55
@legobeat legobeat requested a review from a team as a code owner June 18, 2024 03:55
@legobeat legobeat requested a review from a team June 18, 2024 04:06
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.42%. Comparing base (624763a) to head (768fb9f).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25372      +/-   ##
===========================================
- Coverage    65.42%   65.42%   -0.00%     
===========================================
  Files         1380     1380              
  Lines        54688    54688              
  Branches     14339    14339              
===========================================
- Hits         35776    35775       -1     
- Misses       18912    18913       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat merged commit 4147b2d into MetaMask:develop Jun 18, 2024
83 of 84 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@metamaskbot metamaskbot added the release-11.16.13 Issue or pull request that will be included in release 11.16.13 label Jun 21, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-11.16.13 on PR, as PR was cherry-picked in branch 11.16.13.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-11.16.13 Issue or pull request that will be included in release 11.16.13 team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants