Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display the correct symbol of a native currency #25364

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Jun 17, 2024

Description

This PR fixes a small bug in the display of certain types of notifications. Specifically, in the case of receiving or sending notifications of native currencies, the symbol of the native currency is now correctly displayed.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

Screenshot 2024-06-17 at 11 16 01

After

Screenshot 2024-06-17 at 11 43 31

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matteoscurati matteoscurati added the team-notifications Notifications team label Jun 17, 2024
@matteoscurati matteoscurati marked this pull request as ready for review June 17, 2024 09:49
@matteoscurati matteoscurati requested a review from a team as a code owner June 17, 2024 09:49
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.42%. Comparing base (624763a) to head (020921d).

Files Patch % Lines
...components/eth-sent-received/eth-sent-received.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25364   +/-   ##
========================================
  Coverage    65.42%   65.42%           
========================================
  Files         1380     1380           
  Lines        54688    54688           
  Branches     14339    14339           
========================================
  Hits         35776    35776           
  Misses       18912    18912           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [020921d]
Page Load Metrics (52 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6210686105
domContentLoaded9171121
load41645263
domInteractive9171121
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 2 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@matteoscurati matteoscurati merged commit ed06176 into develop Jun 18, 2024
80 checks passed
@matteoscurati matteoscurati deleted the fix/show-native-currency-symbol branch June 18, 2024 09:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants