-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump Snaps packages #25292
chore: Bump Snaps packages #25292
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected] |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
@@ -1391,7 +1393,6 @@ export default class MetamaskController extends EventEmitter { | |||
state: initState.SnapsRegistry, | |||
messenger: snapsRegistryMessenger, | |||
refetchOnAllowlistMiss: requireAllowlist, | |||
failOnUnavailableRegistry: requireAllowlist, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We removed this constructor arg a while ago but forgot to delete it
@SocketSecurity ignore npm/@metamask/[email protected] |
39125ed
to
77346a6
Compare
77346a6
to
84e6af5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25292 +/- ##
========================================
Coverage 65.38% 65.39%
========================================
Files 1382 1382
Lines 54767 54759 -8
Branches 14368 14366 -2
========================================
- Hits 35809 35806 -3
+ Misses 18958 18953 -5 ☔ View full report in Codecov by Sentry. |
Builds ready [84e6af5]
Page Load Metrics (44 ± 2 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0. |
Description
Bump snaps packages to latest and handle breaking changes.
Depends on #25302Summary of changes in the snaps deps:
tooltip
prop onRow
onNameLookup
response to includedomainName