Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Snaps packages #25292

Merged
merged 4 commits into from
Jun 19, 2024
Merged

chore: Bump Snaps packages #25292

merged 4 commits into from
Jun 19, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jun 13, 2024

Description

Bump snaps packages to latest and handle breaking changes.

Depends on #25302

Summary of changes in the snaps deps:

  • Breaking: Defer creation of offscreen document
  • Fix an issue with decrypting legacy state blobs
  • Support nested children in JSX
  • Allow usage of the tooltip prop on Row
  • Revert requiring at least one child in JSX components
  • Update onNameLookup response to include domainName

Open in GitHub Codespaces

@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label Jun 13, 2024
Copy link

socket-security bot commented Jun 13, 2024

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 13, 2024
Copy link

socket-security bot commented Jun 13, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@@ -1391,7 +1393,6 @@ export default class MetamaskController extends EventEmitter {
state: initState.SnapsRegistry,
messenger: snapsRegistryMessenger,
refetchOnAllowlistMiss: requireAllowlist,
failOnUnavailableRegistry: requireAllowlist,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed this constructor arg a while ago but forgot to delete it

@FrederikBolding
Copy link
Member Author

@SocketSecurity ignore npm/@metamask/[email protected]
Network access expected.

@FrederikBolding FrederikBolding force-pushed the fb/snaps-bump-v52 branch 3 times, most recently from 39125ed to 77346a6 Compare June 18, 2024 11:43
@FrederikBolding FrederikBolding marked this pull request as ready for review June 18, 2024 11:44
@FrederikBolding FrederikBolding requested review from a team as code owners June 18, 2024 11:44
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.39%. Comparing base (da4b61c) to head (84e6af5).

Files Patch % Lines
app/scripts/metamask-controller.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25292   +/-   ##
========================================
  Coverage    65.38%   65.39%           
========================================
  Files         1382     1382           
  Lines        54767    54759    -8     
  Branches     14368    14366    -2     
========================================
- Hits         35809    35806    -3     
+ Misses       18958    18953    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [84e6af5]
Page Load Metrics (44 ± 2 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint66977884
domContentLoaded9121010
load39584442
domInteractive9121010
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -22.01 KiB (-0.63%)
  • ui: 24 Bytes (0.00%)
  • common: -96.31 KiB (-1.47%)

@FrederikBolding FrederikBolding merged commit b0f57cf into develop Jun 19, 2024
84 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v52 branch June 19, 2024 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2024
@metamaskbot metamaskbot added release-12.1.0 Issue or pull request that will be included in release 12.1.0 release-12.0.0 Issue or pull request that will be included in release 12.0.0 and removed release-12.1.0 Issue or pull request that will be included in release 12.1.0 labels Jun 19, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants