Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump accounts-controller to version 16.0.0 #25201

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

montelaidev
Copy link
Contributor

Description

This PR bumps the @metamask/accounts-controller to ^16.0.0

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev montelaidev requested a review from a team as a code owner June 11, 2024 08:36
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None +13 2.6 MB

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@ccharly ccharly changed the title chore: bump accounts controller 16 chore: bump accounts-controller to version 16.0.0 Jun 11, 2024
@ccharly ccharly changed the title chore: bump accounts-controller to version 16.0.0 chore(deps): bump accounts-controller to version 16.0.0 Jun 11, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [044d6c1]
Page Load Metrics (132 ± 172 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint68346965828
domContentLoaded9161121
load401692132358172
domInteractive9161121
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.59%. Comparing base (1af66fb) to head (044d6c1).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25201   +/-   ##
========================================
  Coverage    65.59%   65.59%           
========================================
  Files         1362     1362           
  Lines        54167    54167           
  Branches     14167    14167           
========================================
  Hits         35527    35527           
  Misses       18640    18640           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccharly ccharly merged commit 1e18d45 into develop Jun 11, 2024
85 checks passed
@ccharly ccharly deleted the bump-accounts-controller-16-2 branch June 11, 2024 09:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants