Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await account render after unlock before checking for mocked endpoint… #21422

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Oct 18, 2023

… resolution in unlock-wallet.spec.js

Description

Fixes the flakiness of the should send first three Page metric events upon fullscreen page load test when run as part of the test-e2e-chrome-mmi job. While this seems to fix the issue, I don't have a 100% definite explanation. My hypothesis in making the change in this PR is that occasionaly on mmi builds the e2e tests would take longer to get past the unlock stage than expected, and so it is possible that not all metrics requests that the unlock-wallet.spec.js test is waiiting for have be made by the time the test starts looking for them.

Anecdotal evidence seems to suggest that this has worked, and that this test is passing.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm marked this pull request as ready for review October 18, 2023 02:42
@danjm danjm requested a review from a team as a code owner October 18, 2023 02:42
@metamaskbot
Copy link
Collaborator

Builds ready [d7cdc9d]
Page Load Metrics (1079 ± 435 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint85147108209
domContentLoaded67152982211
load7823681079905435
domInteractive67152982211
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham merged commit 239f0c5 into develop Oct 18, 2023
9 of 10 checks passed
@HowardBraham HowardBraham deleted the fix-flaky-mmi-chrome-test branch October 18, 2023 04:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
@metamaskbot metamaskbot added the release-11.5.0 Issue or pull request that will be included in release 11.5.0 label Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.5.0 Issue or pull request that will be included in release 11.5.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants