Await account render after unlock before checking for mocked endpoint… #21422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… resolution in unlock-wallet.spec.js
Description
Fixes the flakiness of the
should send first three Page metric events upon fullscreen page load
test when run as part of thetest-e2e-chrome-mmi
job. While this seems to fix the issue, I don't have a 100% definite explanation. My hypothesis in making the change in this PR is that occasionaly on mmi builds the e2e tests would take longer to get past the unlock stage than expected, and so it is possible that not all metrics requests that theunlock-wallet.spec.js
test is waiiting for have be made by the time the test starts looking for them.Anecdotal evidence seems to suggest that this has worked, and that this test is passing.
Pre-merge author checklist
Pre-merge reviewer checklist