Use getEncryptionPublicKey from Core KeyringController

[cryptodev-2s]

Explanation

This PR uses getEncryptionPublicKey from core KeyringController instead of calling EthKeyringController directly.

• Fixes Refactor EncryptionPublicKeyController to use @metamask/keyring-controller #20206

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @metamask/[email protected], @metamask/[email protected]

[mcmire]

Looks good aside from one thing.

[metamaskbot]

Builds ready [6640834]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1513 ± 34 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	107	156	125	13	6
		domContentLoaded	1424	1660	1512	72	34
		load	1424	1660	1513	72	34
		domInteractive	1424	1660	1512	72	34

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 724 Bytes (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3f5bc97) 68.83% compared to head (6640834) 68.83%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #20646   +/-   ##
========================================
  Coverage    68.83%   68.83%           
========================================
  Files          997      997           
  Lines        38906    38906           
  Branches     10443    10443           
========================================
  Hits         26778    26778           
  Misses       12128    12128           

Files Changed	Coverage Δ
app/scripts/metamask-controller.js	65.54% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mikesposito]

LGTM!

[mcmire]

Looks good!