Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on e2e test failure #16556

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 17, 2022

If an e2e test fails on a website, the driver will crash on this line because it can't find a reference to stateHooks. That variable is only set in our UI, not on other sites.

Manual Testing Steps

Not sure this needs manual testing. An example of the crash is here though: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/30900/workflows/90e1609a-a961-438b-b328-651eb2e0e00c/jobs/806238

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

If an e2e test fails on a website, the driver will crash on this line
because it can't find a reference to `stateHooks`. That variable is
only set in our UI, not on other sites.
@Gudahtt Gudahtt marked this pull request as ready for review November 17, 2022 13:38
@Gudahtt Gudahtt requested a review from a team as a code owner November 17, 2022 13:38
@Gudahtt Gudahtt requested a review from Gtonizuka November 17, 2022 13:38
@metamaskbot
Copy link
Collaborator

Builds ready [e02a421]
Page Load Metrics (2107 ± 123 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint921876205384184
domContentLoaded164125372082253121
load164126142107257123
domInteractive164125372082253121
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@Gudahtt Gudahtt merged commit 0841c1d into develop Nov 17, 2022
@Gudahtt Gudahtt deleted the fix-crash-on-e2e-test-failure branch November 17, 2022 14:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants