Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): de lightTheme translation #16517

Merged
merged 3 commits into from
Nov 16, 2022
Merged

fix(i18n): de lightTheme translation #16517

merged 3 commits into from
Nov 16, 2022

Conversation

paulbuechner
Copy link
Contributor

Explanation

Fix german localization translation for lightTheme

Screenshots/Screencaps

Before

Leicht

After

Hell

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@paulbuechner paulbuechner requested a review from a team as a code owner November 15, 2022 21:18
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@paulbuechner
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit a5b70c3 into MetaMask:develop Nov 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2022
@paulbuechner paulbuechner deleted the patch-1 branch November 16, 2022 23:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants