Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version v10.22.1 RC #16504

Merged
merged 7 commits into from
Nov 15, 2022
Merged

Version v10.22.1 RC #16504

merged 7 commits into from
Nov 15, 2022

Conversation

metamaskbot
Copy link
Collaborator

📦 🚀

@socket-security
Copy link

socket-security bot commented Nov 15, 2022 •
edited
Loading

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Ignoring: [email protected], [email protected]

Powered by socket.dev

Gudahtt and others added 3 commits November 15, 2022 12:11
@Gudahtt
Restore v10.22.0 changelog
12d0fc4
@danjm @Gudahtt
Prevent user from editing a contract interaction created by a dapp (#…
6473b7d 
…16498)

* Prevent user from editing a contract interaction created by a dapp

* Code cleanup

* Fix e2e test selector

* Fix e2e test

* Fix e2e test

* Update snapshot
@Gudahtt
Update changelog
097c8a2
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Gudahtt
Ignore advisary related to 3Box
3da175c 
3Box was removed in v10.22.0, so this advisory will be obsolete in the
subsequent release, which is being prepared already.
@Gudahtt
Copy link
Member

Gudahtt commented Nov 15, 2022

@SocketSecurity ignore [email protected] [email protected]

These are only being introduced here because of the temporary revert; they'll be gone soon.

@Gudahtt Gudahtt marked this pull request as ready for review November 15, 2022 16:02
@Gudahtt Gudahtt requested review from a team and kumavis as code owners November 15, 2022 16:02
@Gudahtt Gudahtt requested a review from darkwing November 15, 2022 16:02
@Gudahtt
Copy link
Member

Gudahtt commented Nov 15, 2022

The new e2e test is broken because it uses the fixture builder only available on develop. I'll adapt the test now to use the old fixtures.

@Gudahtt
Fix e2e test
69ccb37 
The new e2e test added for the bug fix being released here has been
updated to use the old e2e test fixtures, rather than the fixture-
builder. The fixture builder is not available on this branch yet.
@metamaskbot
Copy link
Collaborator Author

Builds ready [69ccb37]
Page Load Metrics (2294 ± 131 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint902029203419201
domContentLoaded169628532269253121
load169629482294273131
domInteractive169528532269253121

highlights:

storybook

@Gudahtt
Copy link
Member

Gudahtt commented Nov 15, 2022

@seaona reported on Slack that this has passed QA

@Gudahtt Gudahtt merged commit ffd1e58 into master Nov 15, 2022
@Gudahtt Gudahtt deleted the Version-v10.22.1 branch November 15, 2022 17:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

@darkwing darkwing Awaiting requested review from darkwing darkwing is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metamaskbot @Gudahtt @danjm