Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Fix an issue with updating snaps that have caveat permissions #16473

Conversation

FrederikBolding
Copy link
Member

Explanation

Fixes an issue with updating snaps that had caveat permissions.

Manual Testing Steps

  1. Install a previous version of the BIP44 test snap
  2. Try to update the snap to the latest version
  3. See that this fails on the current build of Flask but not this branch.

@metamaskbot
Copy link
Collaborator

Builds ready [0ed4c6f]
Page Load Metrics (2097 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint872141203445213
domContentLoaded16792371207718890
load16802371209718890
domInteractive16792371207718890
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@FrederikBolding FrederikBolding merged commit 8f30e03 into develop Nov 14, 2022
@FrederikBolding FrederikBolding deleted the fb/fix-issue-with-updating-snaps-with-caveat-permissions branch November 14, 2022 10:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants