Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: To differentiate between which chrome alarm is triggered #16360

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

NiranjanaBinoy
Copy link
Contributor

#16359
With the chrome.alarms.getAll, we are getting the list of all the alarms currently active, and it is not the right way to get which alarm that was triggered at that moment; for that, we can use the alarm information from addListener prop.

Manual testing:

  1. Log in to the application
  2. Go to settings >> search for Auto-lock timer (minutes)
  3. Set a timer value; A value greater than 1 minute will be easier to test as the second alarm we have is for a 1 min window.
  4. Breakpoint at line 210 in app-state and check if it goes off at the interval you have defined at Auto-lock timer (minutes)
  5. Breakpoint at line 167 metametrics.js and check if it goes off every minute.

@NiranjanaBinoy NiranjanaBinoy self-assigned this Nov 2, 2022
@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner November 2, 2022 18:51
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NiranjanaBinoy NiranjanaBinoy added the PR - P1 identifies PRs deemed priority for Extension team label Nov 2, 2022
@NiranjanaBinoy NiranjanaBinoy changed the title Fix to differentiate between which alarm is triggered Fix: To differentiate between which chrome alarm is triggered Nov 2, 2022
@hilvmason hilvmason removed the MV3 label Nov 3, 2022
@NiranjanaBinoy NiranjanaBinoy merged commit 3903768 into develop Nov 4, 2022
@NiranjanaBinoy NiranjanaBinoy deleted the alarm-addlistener branch November 4, 2022 15:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR - P1 identifies PRs deemed priority for Extension team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome alarm is not identifying which alarm is getting triggered correctly.
4 participants