Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused zh locales directory in favor of zh_CN #16322

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Oct 31, 2022

Explanation

zh_CN is the correct language code for our Chinese translations. Crowdin was mistakenly pushing them to the zh language code directory for a while. This was fixed as of this PR and so zh translations are no longer updated and will not be used. I have verified that the zh_CN locale file has since been correctly updated with all translations and is currently up to date minus any pending translations present in the current Crowdin (github actions) PR.

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@adonesky1 adonesky1 requested a review from a team as a code owner October 31, 2022 14:44
@adonesky1 adonesky1 requested a review from ryanml October 31, 2022 14:44
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Gudahtt
Gudahtt previously approved these changes Oct 31, 2022
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [94a87a6]
Page Load Metrics (2213 ± 173 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint891941142612
domContentLoaded164031412196340163
load164032762213359173
domInteractive164031412196340163

@metamaskbot
Copy link
Collaborator

Builds ready [691a77b]
Page Load Metrics (2332 ± 131 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint913041285225
domContentLoaded185928342320280135
load189128342332274131
domInteractive185928342320280135

@adonesky1 adonesky1 merged commit 08a4f93 into develop Oct 31, 2022
@adonesky1 adonesky1 deleted the remove-zh branch October 31, 2022 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants