Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync v10.21.0 with develop #16309

Merged
merged 31 commits into from
Oct 31, 2022
Merged

Sync v10.21.0 with develop #16309

merged 31 commits into from
Oct 31, 2022

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Oct 29, 2022

Sync the v10.21.0 release with develop.

seaona and others added 30 commits October 27, 2022 20:27
#16042)

* Fix: show whats new to users who created, not imported, a new wallet, but not on their first session

* Fix tests

Hide `Improved token detection is here` & `Scam and security risks`  whats new

* Fix unit test

Co-authored-by: PeterYinusa <[email protected]>
We now use the `latest` tag for the phishing warning page, we now use
the version that matches what we have in our manifest. This ensures
that our phishing warning e2e tests match the behaviour of the
production build, and it ensures that breaking changes to the phishing
warning page don't impact users in production.
* 16083: Fix deposit eth popover layout

* adding responsive padding updates

* classname fix

* Add custom classname option
* Raw changelog 10.21.0

* Changelog Cleanup

* Flask - support blocking Snaps

Co-authored-by: Frederik Bolding <[email protected]>

* Flask - snap_getBip32PublicKey

Co-authored-by: Frederik Bolding <[email protected]>

* Flask - transaction insights

Co-authored-by: Frederik Bolding <[email protected]>

* Remove bump keystone entry from changelog

Co-authored-by: Frederik Bolding <[email protected]>
* [email protected]

* Update LavaMoat policies

* Bump execution environment and fix a breaking change

* Fix caveat and permissions

* Fix test

* Exclude keyring endowment for now

* Fix test

* Fix snap_confirm missing title
This update includes fixes for our `block-ref` and `retry-on-empty`
middleware.

The `block-ref` middleware resolves the block reference `latest` to a
specific block number, the latest one we are aware of. This is meant to
protect against situations where the network gives inconsistent answers
for what the latest block number is due to some nodes being out-of-sync
with each other (this was a frequent problem years ago with Infura).

It was broken in that the `latest` resolution was failing, and we were
submitting an additional redundant request to Infura for each request.

The `retry-on-empty` middleware is meant to retry certain methods
when they return an empty response. This was also meant to deal with
network synchronization issues that were more common years ago. This
middleware works by making a "child" request over and over until either
a retry limit is reached, or a non-empty response is received.

It was broken in that the final response recieved was thrown away, so
it's as though the middleware was not used. Except that it did result
in additional redundant network requests.

As a result of this update we should see that the extension is more
resilient to certain network synchronization issues. But this is
difficult to test, and these issues may not happen in production
anymore today.

We should see a reduction in requests to Infura as well. This should
be easier to test.
* [email protected]

* Update LavaMoat policies

* Fix eth_accounts permission for Snaps

* Update iframe execution environment

* Dedupe yarn.lock and rerun LavaMoat policy gen

* Add policy override for nanoid
* Fix inputs that should allow decimals

* Update e2e test to cover inputting of decimals in advanced fields

* Update e2e test to cover inputting of decimals in advanced fields

* Fix e2e tests
* Updating controller dependency

* fix

* fix

* fix

* fix

* fixes

* Lavamoat auto

* Update URLs for phishing detection testcase

* update lavamoat files

* call phishingController.test synchronously again

* bump @metamask/controllers to v32.0.1

* lint

* update policy files

* bump controllers version again

* modify update phishing list strategy

* revert back to use isOutOfDate, but without blocking substream

* possible way to fix e2e tests?

* enable testing

* Remove promise return from setupController in background.js, as it is no longer used

* Ensure updatePhishingLists is called in MM contrller constructer, so that phishing lists are updated right away

Co-authored-by: seaona <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Dan Miller <[email protected]>
#16102)

* Remove ETH badge from NetworkAccountBalanceHeader when on non-ETH networks

* Network specific icons, or fallback, in the network-account-balance-header

* Update snapshots

* Code cleanup

Co-authored-by: Dan Miller <[email protected]>
* Enable "Add Popular Network" feature by default

* Fixing e2e tests

* Attempt to fix e2e tests

* Revert "Attempt to fix e2e tests"

This reverts commit d88e894.

* Get e2e tests passing

Co-authored-by: Dan J Miller <[email protected]>
* Last changelog updates with recently added PRs

* Remove snaps-skunkworks from Changelog

Co-authored-by: Frederik Bolding <[email protected]>

* Fix snaps issue that request eth_accounts permission

Co-authored-by: Frederik Bolding <[email protected]>

* Move flask PR to fixed section

Co-authored-by: Frederik Bolding <[email protected]>
* Use stable version of Jest

* Update Jest config
* origin/develop: (79 commits)
  Exclude E2E tests for swaps until they are stabilised (#16303)
  Add e2e tests for Swaps notifications (#16202)
  E2e test fixtures (#16061)
  Improve transaction confirmation page performance (#16205)
  [MV3] Fix e2e `encrypt-decrypt` test for MV3 test build (#16264)
  Fix e2e incremental-secuirty test for mv3 build (#16265)
  Enable "Add Popular Network" feature by default for all users (#16172)
  [e2e] Fix Dapp interactions flaky test on chrome (#16282)
  [FLASK] Allow snaps insights to show on regular EOA transactions (#16093)
  TextFieldBase updates after design reveiw (#16201)
  Adding `TextField` component (#16105)
  Remove ETH badge from NetworkAccountBalanceHeader when on non-ETH net… (#16102)
  Updating controller dependency (#16033)
  Fix inputs that should allow decimals (#16254)
  Chromedriver v106 (#16213)
  [FLASK] Clear snap state on restore (#16228)
  [FLASK] Fix flaky BIP-32 E2E test (#16255)
  Continue converting tests from enzyme to @testing-library/react (#16175)
  Fix/16207/text component storybook (#16214)
  ci: fix stats-module-load-init step (#16196)
  ...
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Gudahtt Gudahtt marked this pull request as ready for review October 29, 2022 01:45
@Gudahtt Gudahtt requested a review from a team as a code owner October 29, 2022 01:45
@Gudahtt Gudahtt requested a review from digiwand October 29, 2022 01:45
@metamaskbot
Copy link
Collaborator

Builds ready [ba16fd9]
Page Load Metrics (2128 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint852126207441212
domContentLoaded18392291210213866
load18422291212813364
domInteractive18392291210213866

@digiwand
Copy link
Contributor

once the test-deps-audit 3box is resolved...

Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems the test-deps-audit 3box issue is out of this scope and is something to fix with develop

@Gudahtt Gudahtt merged commit 143793c into develop Oct 31, 2022
@Gudahtt Gudahtt deleted the sync-master branch October 31, 2022 17:13
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [f8e01a0]
Page Load Metrics (2383 ± 191 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint952286294500240
domContentLoaded162035172352398191
load162035172383399191
domInteractive162035172352398191

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.