Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of MM after rejecting a transaction - FR #7670

Closed
prographo opened this issue Dec 9, 2019 · 3 comments
Closed

Behaviour of MM after rejecting a transaction - FR #7670

prographo opened this issue Dec 9, 2019 · 3 comments

Comments

@prographo
Copy link

This is not a bug, I just think the way MM behaves is "odd"

If the MM pops up because a website has initiated a transaction, (ofc due ultimately to the user's interaction with the website), this is good. If a subsequent transaction is initiated, the popup appears once again, this is also good and what I would expect.

However:

If the MM popup is rejected, subsequent transactions initiated by the website do NOT launch the popup, instead the popup is hidden, all that shows is a notification on the MM icon in the bar at the top (chrome). I think this is wrong, the popup should appear again, every time. It is confusing because it is inconsistent behaviour.

@Gudahtt
Copy link
Member

Gudahtt commented Dec 9, 2019

This sounds like #7051 - except you've managed to find the steps to reproduce this.

@prographo
Copy link
Author

Indeed, good spot - although they are vague on how to reproduce, do what I said, you will see it everytime.

@tmashuang
Copy link
Contributor

Fixed by #8446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants