Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signTypedDataV3Button make distinct class for puppeteer selector #6073

Closed
rstormsf opened this issue Jan 30, 2019 · 1 comment
Closed

signTypedDataV3Button make distinct class for puppeteer selector #6073

rstormsf opened this issue Jan 30, 2019 · 1 comment

Comments

@rstormsf
Copy link

image

It would be really awesome if I could have a unique selector for sign button similar to cancel button

@whymarrh
Copy link
Contributor

whymarrh commented Feb 8, 2019

@trowacat fixed this with #6120, cheers

Btw, we don't go out of our way to change classes on you but know that using the classes is brittle 😅

@whymarrh whymarrh closed this as completed Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants