Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sent token amounts in transaction list when ETH is selected #6055

Closed
danjm opened this issue Jan 22, 2019 · 1 comment
Closed

Show sent token amounts in transaction list when ETH is selected #6055

danjm opened this issue Jan 22, 2019 · 1 comment
Labels
area-UI Relating to the user interface.

Comments

@danjm
Copy link
Contributor

danjm commented Jan 22, 2019

In the transaction list, if ETH is selected in the token sidebar, the sent amount shown next to a token transaction is "0 ETH". This is not useful information and can actually confuse users into thinking that they did not send anything with that transaction when in fact tokens were sent.

To recreate this:
(1) send tokens from MetaMask
(2) send an eth transaction with a non-zero eth amount
(3) Select the "Eth" option in the token sidebar on the home screen of the app
(4) Look at the amount sent info on the right side of the two rows corresponding to the two transactions you just sent

Meanwhile, if you select the token you just sent in the sidebar, the transaction row will correctly display the amount of token sent on the right side of the row.

We should change the behaviour of transactions so that, if they are token transactions, they display the token amount sent, instead of "0 ETH" on the right side of the transaction row.

Relevant screen shots:

screenshot from 2019-01-22 11-50-59

screenshot from 2019-01-22 11-50-51

@danjm danjm added area-UI Relating to the user interface. in progress labels Jan 22, 2019
@brad-decker
Copy link
Contributor

Resolved in #8564 , further refinements coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface.
Projects
None yet
Development

No branches or pull requests

4 participants