Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trezor hardware wallet support #605

Closed
mcgravier opened this issue Sep 2, 2016 · 14 comments
Closed

Add Trezor hardware wallet support #605

mcgravier opened this issue Sep 2, 2016 · 14 comments
Assignees
Labels
area-background Issues relating to the extension background process. needs-design Needs design support. type-enhancement

Comments

@mcgravier
Copy link

mcgravier commented Sep 2, 2016

Trezor Ethereum support has been included in the latest firmware upgrade, however, there are no wallets supporting it avialiable - AFAIK there is work on Mist support being in progress, but MetaMask would be far better suited for average user

@danfinlay
Copy link
Contributor

We definitely want to support various signing methods long term. We're hoping to implement a signing plugin system to make this sort of thing easier, hopefully we'll get to that soon!

@danfinlay
Copy link
Contributor

danfinlay commented Sep 12, 2016

Blocked by #328

@mcgravier
Copy link
Author

Any progress on hardware wallet support? I see that multiple account type support has been merged - any chance for picking up Trezor/Ledger/Keepkey anytime soon?

@danfinlay
Copy link
Contributor

Hopefully fairly soon. We'll be doing Ledger first probably, since I have one, but none of us have a Trezor (and they didn't get back to me about a dev device ;) ).

@woodydeck
Copy link

Have you acquired a Trezor yet for testing? These are currently much more available than the ledger s nanos.

Try the /r/Trezor subreddit if email doesn't go through. They have pretty good documentation available for integrations, but it is a bit steep the first time.

@danfinlay
Copy link
Contributor

I have, thanks! Very much looking forward to adding this.

@woodydeck
Copy link

Great! There's a wonderful woocommerce plugin someone developed with metamask in mind, https://www.paywithether.com. This shows why HW wallet support is so vital.

Their solution for callbacks to woocommerce, since ethereum isn't great for HD walleting, is to add a tx ID to the send so their API can do a callback for the right order. Metamask makes this operation a one-click jobby, but I just don't see people sending hundreds of dollars worth of ether to metamask to checkout. We are currently stuck with MEW or the exchanges (coinbase doesn't have good ethereum support), and this plugin isn't exactly ideal for use this way.

Mist is also still stuck on the HW wallet issue, so this is a good way to get a leg up on them. Most of my friends can figure out how to buy a Trezor and install a Chrome plugin, but when you start talking about geth, downloading the blockchain with --light, and browsing through a specialized browser, they start to blue screen. I personally would never crypto for more than grocery money unless I had the peace of mind from a HW wallet.

Finally, I don't know if there is an issue to this, but Macbooks with the touchbar have biometric support now. This could be a cool way to get some attention from that crowd if integrated. Apple for better or worse is a great litmus test for high value consumers.

@bbozo
Copy link

bbozo commented Sep 26, 2017

I personally would never crypto for more than grocery money unless I had the peace of mind from a HW wallet.

This

@kilimchoi
Copy link

Any progress on this?

@danfinlay
Copy link
Contributor

Yes, this has been set back very far, but I think other pieces are now in place that will allow us to pursue this in the next few months.

@prusnak
Copy link

prusnak commented Jan 22, 2018

TREZOR support has been merged to Geth: ethereum/go-ethereum#14885, so there is hopefully nothing blocking the integration with Metamask. If yes, let me know!

@danfinlay
Copy link
Contributor

MetaMask integration has nothing to do with Geth support. For a recent update on our blockers, refer to this thread.

@2-am-zzz 2-am-zzz added area-background Issues relating to the extension background process. P2-sooner needs-design Needs design support. labels Mar 2, 2018
@2-am-zzz 2-am-zzz removed this from the New UI Public Release milestone Mar 2, 2018
@brunobar79 brunobar79 mentioned this issue Jun 21, 2018
24 tasks
@ghost ghost assigned brunobar79 Jun 21, 2018
@ghost ghost added the in progress label Jun 21, 2018
@bdresser bdresser removed the blocked label Jul 10, 2018
@bdresser
Copy link
Contributor

@brunobar79 @cjeria when you can, report back on the results of your design convo!

@bdresser bdresser added this to the Sprint 07 [7.9 - 7.20] milestone Jul 10, 2018
@bdresser
Copy link
Contributor

design fixes: MetaMask/Design#33

generally tracking progress in the PR (#4625) for those following along

@ghost ghost removed the in progress label Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-background Issues relating to the extension background process. needs-design Needs design support. type-enhancement
Projects
None yet
Development

No branches or pull requests

9 participants