Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong function type when sending ETH #6002

Closed
estebanmino opened this issue Jan 7, 2019 · 2 comments
Closed

Wrong function type when sending ETH #6002

estebanmino opened this issue Jan 7, 2019 · 2 comments
Assignees
Labels
area-UI Relating to the user interface. type-discussion

Comments

@estebanmino
Copy link
Contributor

Describe the bug

When sending an ETH transaction with hex data, Function Type is CONTRACT INTERACTION even though I'm not interacting with a contract.

To Reproduce
Steps to reproduce the behavior:

Follow the GIF

bugg

Expected behavior
Should have the same behavior, regarding Function Type, when sending ETH without hex data.

Screenshots
If applicable, add screenshots to help explain your problem.

Browser details (please complete the following information):

  • OS: Ubuntu
  • Browser Chrome
  • MetaMask Version 5.3.0

Additional context
Add any other context about the problem here.

@bdresser
Copy link
Contributor

bdresser commented Jan 8, 2019

If a normal send has hex data attached, it's very tough for us to distinguish it from a contract interaction. @alextsg this has come up before, yes?

@alextsg
Copy link
Contributor

alextsg commented Jan 8, 2019

@bdresser We can make an external request to check if the recipient is a smart contract address, which is what we're doing in the transactions view. I can make that change here as well.

@alextsg alextsg self-assigned this Jan 8, 2019
@bdresser bdresser added the area-UI Relating to the user interface. label Jan 8, 2019
@ghost ghost added the in progress label Jan 10, 2019
@ghost ghost removed the in progress label Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. type-discussion
Projects
None yet
Development

No branches or pull requests

3 participants