Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Viewing of Pending Transactions #5748

Closed
tmashuang opened this issue Nov 13, 2018 · 1 comment
Closed

Allow Viewing of Pending Transactions #5748

tmashuang opened this issue Nov 13, 2018 · 1 comment

Comments

@tmashuang
Copy link
Contributor

tmashuang commented Nov 13, 2018

What problem are you trying to solve?
#5739
#4760
#5687
I believe somehow Pending Transactions(Transactions that have not been submitted but approved?) are showing up in the transaction history. I am still unsure how users are getting pasted the transaction confirmation without either confirming/rejecting the transactions. Possible issues could be that we are populating the Mainnet tx history with Custom RPC/Ganache txs via getting metamaskNetworkId is incorrect. Another theory is dropped txs are coming back. Either way the local nonce is incorrectly calculate with the list of pending txs. I believe the only way to clear them now is to Reset Account.

Describe the solution you'd like
Be able to view all pending txs and reject them.

Additional context
These pending tx aren't transitioning to failed/dropped.

@brad-decker
Copy link
Contributor

@tmashuang this issue seems old due to the fact that we now display pending txs and allow cancel/retry/etc -- can you confirm and close if this is out of date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants