Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction Details Improvements #5355

Closed
danfinlay opened this issue Sep 25, 2018 · 2 comments
Closed

Transaction Details Improvements #5355

danfinlay opened this issue Sep 25, 2018 · 2 comments
Labels
area-UI Relating to the user interface.

Comments

@danfinlay
Copy link
Contributor

A couple notes on the new tx details views:

  • I kinda think the "speed up" and "cancel" buttons should be visible on the main tx cell, even without clicking into the tx, since many of our users are conditioned to think clicking will take them away to etherscan.

  • Clicking "speed up" should close the tx details modal.

Other than that:

Omg I love this feature.
@danfinlay danfinlay added the area-UI Relating to the user interface. label Sep 25, 2018
@bdresser
Copy link
Contributor

@danfinlay i totally agree

having "speed up" close the modal seems mandatory for 4.12. upgrading those two buttons to the main tx view can wait I think? @alextsg

@bdresser
Copy link
Contributor

closing this and making two separate issues

speed up / modal #5373

increasing speed up / cancel visibility #5374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-UI Relating to the user interface.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danfinlay @bdresser