Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if known nonce is higher than pending tx #5031

Closed
bdresser opened this issue Aug 10, 2018 · 2 comments · Fixed by #6388
Closed

Check if known nonce is higher than pending tx #5031

bdresser opened this issue Aug 10, 2018 · 2 comments · Fixed by #6388
Assignees

Comments

@bdresser
Copy link
Contributor

If users submit tx outside MetaMask it can cause us to lose track of which tx are actually pending, which can affect which transaction we ask the user to reprice / speed up.

As described in #4974 (comment), we can check on pending tx if the account's known nonce has exceeded the pending transaction in metamask and if so transition the status to dropped.

@rstormsf
Copy link

rstormsf commented Mar 17, 2019

Bump.
I just experienced an issue due to stalled pending txs.
Metamask becames unusuable. What I had is the following:
Send tx with less than acceptable gas price: 0.1 gwei on kovan
Send some more txs on top.
Send tx outside of metamask to drop pending txs.

Result: Metamask still shows old pending tx and it cannot cancel them, the account becomes unusable due to inability to generate new transactions.

@bdresser
Copy link
Contributor Author

@rstormsf thanks for the bump

as a fix in the meantime, doing a "reset account" from settings should force the extension to re-sync your nonce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants