Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.9.0 breaks eth_signTypedData #5014

Closed
shaharsol opened this issue Aug 9, 2018 · 3 comments
Closed

v4.9.0 breaks eth_signTypedData #5014

shaharsol opened this issue Aug 9, 2018 · 3 comments

Comments

@shaharsol
Copy link

my code that used to work:

web3.currentProvider.sendAsync({
      method: 'eth_signTypedData',
      params: [params, App.account],
      from: App.account,
    }, function (err, result) {
      callback(err,result)
    })

now I get this message in the console but nothing happens:

screen shot 2018-08-09 at 6 52 37 pm

@shaharsol
Copy link
Author

It's sporadic, but in some cases after I click the button that fires this function and then explicitly click the metamask fox on the toolbar, I get this window, which I'd expected to pop up:

screen shot 2018-08-09 at 7 02 45 pm

yet, even after I sign, the callback is not called within my js code.

@shaharsol
Copy link
Author

on another desktop, when i click "sign" i see an endless loading gif, and I managed to grab this from the "old ui" dev tools:

metamask1

I bet the undefined EIP712Domain has something to do with the error?

@bitpshr
Copy link
Contributor

bitpshr commented Aug 9, 2018

Hi @shaharsol. This was caused by a premature version bump of a few of our dependencies and will be fixed by #4989. We plan to do a patch release shortly. Your existing dapp code should begin to work again at that time. Thanks for the issue report and for your patience!

@bitpshr bitpshr closed this as completed Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants