Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show browser notifications when transactions complete. #4203

Closed
danfinlay opened this issue May 6, 2018 · 4 comments
Closed

Show browser notifications when transactions complete. #4203

danfinlay opened this issue May 6, 2018 · 4 comments

Comments

@danfinlay
Copy link
Contributor

danfinlay commented May 6, 2018

We should use the browser notification API to let the user know when a transaction enters a [final state]:

  • confirmed
  • failed
  • dropped

Those three confirmations would have their own texts:

Confirmed tx

Transaction ${tx.nonce} confirmed! View on Etherscan

Failed tx

Transaction ${tx.nonce} failed. (Maybe append tx.error.message)

Dropped tx

A Transaction ${tx.nonce} was dropped, because another transaction with that number was successfully processed.

(We may not want to show this one, especially since it is usually accompanied by a confirmed tx)

Implementation

Should use extensionizer to access the notifications API:

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/notifications

MetaMask does not include platform-specific APIs within the metamask-controller or its dependencies. Instead, functions to showConfirmedTransaction, showFailedTransaction, and showDroppedTransaction should be defined on the extension platform object, which is passed in to the MetaMask controller on initialization:
https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/background.js#L261

@danfinlay danfinlay added this to the Sprint 06 milestone May 6, 2018
@bitpshr bitpshr assigned bitpshr and unassigned bitpshr May 7, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.4 ETH (189.94 USD @ $474.86/ETH) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Jul 19, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 6 months, 3 weeks ago.
Please review their action plans below:

1) scsaba has started work.

No questions so far.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.4 ETH (186.32 USD @ $465.81/ETH) has been submitted by:

  1. @scsaba

@danfinlay please take a look at the submitted work:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.4 ETH (178.17 USD @ $445.42/ETH) attached to this issue has been approved & issued to @scsaba.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants