Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve gas estimation in new-ui send screen #3914

Closed
10 tasks
danjm opened this issue Apr 6, 2018 · 0 comments
Closed
10 tasks

Fix and improve gas estimation in new-ui send screen #3914

danjm opened this issue Apr 6, 2018 · 0 comments
Assignees
Labels
area-UI Relating to the user interface. type-bug type-enhancement
Milestone

Comments

@danjm
Copy link
Contributor

danjm commented Apr 6, 2018

We need to fix and then improve gas estimation in the new-ui send screen.

Requirements include:

  • use the same algorithm for calculating gas as is used in old-ui, be sure to pass same data (when available) to estimateGas
  • on component mount, we need to make an initial estimate without a to address
  • when the to address changes, we need to update the estimate
  • prevent the user from customizing the limit to a value below the minimum required given the estimate
  • if the user customizes the gas limit and then changes the to address, only change the gas limit if it is below the minimum required according to the new estimate
  • Handle the special case of estimating for token transfers.
    • correct value in the to address passed to estimateGas
    • (?) update 'data' when 'To' or amount fields in send form changes (?)
  • Nice to have: update the estimate if blockGasLimit updates
  • Nice to have: give user an indication that the gas limit has been updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. type-bug type-enhancement
Projects
None yet
Development

No branches or pull requests

1 participant