Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize gas modal should use state.metamask.send instead of component state #3793

Closed
danjm opened this issue Mar 29, 2018 · 1 comment
Closed
Labels
area-UI Relating to the user interface. type-enhancement

Comments

@danjm
Copy link
Contributor

danjm commented Mar 29, 2018

Customize gas modal uses its own local component state. Meanwhile, the state is manages is almost all on state.metamask.send. Seems like a potential source of bugs if customize gas modal local state and state.metamask.send get out of sync somehow.

Lets refactor the customize gas modal to use redux state.

(Estimating this as a 3 only because of unknown side effects of the change that we might have to correct.)

@danjm danjm added type-enhancement area-UI Relating to the user interface. labels Mar 29, 2018
@danjm
Copy link
Contributor Author

danjm commented Apr 10, 2018

This will be covered by: #3725

@danjm danjm closed this as completed Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. type-enhancement
Projects
None yet
Development

No branches or pull requests

1 participant