Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Simulation fiat tooltip should show full maxPrecision value, no ellipsis, and not overflow #29716

Open
digiwand opened this issue Jan 15, 2025 · 0 comments
Labels
regression-prod-12.9.2 Regression bug that was found in production in release 12.9.2 Sev3-low Low severity; minimal to no impact upon users team-confirmations Push issues to confirmations team type-bug

Comments

@digiwand
Copy link
Contributor

digiwand commented Jan 15, 2025

Describe the bug

Hovering on fiat value displays the same text when ellipsis is shown in the tooltip.
Image

We should also handle overflow if it still exists
Image

Expected behavior

Hovering on fiat value should display full maxPrecision value and no ellipsis in the tooltip.

Screenshots/Recordings

No response

Steps to reproduce

  1. Set ENABLE_CONFIRMATION_REDESIGN=true to true in .metamaskrc
  2. Enable confirmation_redesign in Launch Darkly
  3. Turn on Improved Signatures setting
  4. Turn on Simulation setting
  5. Open a Permit w/ a large number a. Example: https://develop.d3bkcslj57l47p.amplifyapp.com/ → "Permit 2 - Single" button
  6. Observe value in simulation

Error messages or log output

Detection stage

In production (default)

Version

12.9.2

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@digiwand digiwand added team-confirmations Push issues to confirmations team type-bug labels Jan 15, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 15, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 15, 2025
@metamaskbot metamaskbot added the regression-prod-12.9.2 Regression bug that was found in production in release 12.9.2 label Jan 15, 2025
@benjisclowder benjisclowder added the Sev3-low Low severity; minimal to no impact upon users label Jan 15, 2025
@digiwand digiwand changed the title [Bug]: Simulation fiat tooltip should show full maxPrecision value and no ellipsis [Bug]: Simulation fiat tooltip should show full maxPrecision value, no ellipsis, and not overflow Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-12.9.2 Regression bug that was found in production in release 12.9.2 Sev3-low Low severity; minimal to no impact upon users team-confirmations Push issues to confirmations team type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

3 participants