Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Invalid config parameter: 'name' #27737

Closed
sentry-io bot opened this issue Oct 9, 2024 · 0 comments · Fixed by #27743
Closed

Error: Invalid config parameter: 'name' #27737

sentry-io bot opened this issue Oct 9, 2024 · 0 comments · Fixed by #27743
Labels
regression-prod-12.4.0 Regression bug that was found in production in release 12.4.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-product-safety Push issues to Product Safety team type-bug

Comments

@sentry-io
Copy link

sentry-io bot commented Oct 9, 2024

Sentry Issue: METAMASK-XC7Z

Error: Invalid config parameter: 'name'
  at Array.map (<anonymous>)
...
(2 additional frame(s) were not displayed)
@Gudahtt Gudahtt added type-bug team-product-safety Push issues to Product Safety team labels Oct 9, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Oct 9, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Oct 9, 2024
@Gudahtt Gudahtt added the regression-prod-12.4.0 Regression bug that was found in production in release 12.4.0 label Oct 9, 2024
@MetaMask MetaMask deleted a comment from sentry-io bot Oct 9, 2024
@Gudahtt Gudahtt added Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. Sev2-normal Normal severity; minor loss of service or inconvenience. and removed Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. Sev2-normal Normal severity; minor loss of service or inconvenience. labels Oct 9, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 9, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR fixes an issue that prevented users from receiving the updated
hotlist from ETH Phishing Detect. While the client still fetched the
hotlist, the `PhishingDetector` was unable to update with the new URLs
included in the hotlist.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27743?quickstart=1)

## **Related issues**

Fixes: #27737

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Mark Stacey <[email protected]>
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Oct 9, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 9, 2024
AugmentedMode added a commit that referenced this issue Oct 9, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR fixes an issue that prevented users from receiving the updated
hotlist from ETH Phishing Detect. While the client still fetched the
hotlist, the `PhishingDetector` was unable to update with the new URLs
included in the hotlist.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27743?quickstart=1)

Fixes: #27737

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Mark Stacey <[email protected]>
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-12.4.0 Regression bug that was found in production in release 12.4.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-product-safety Push issues to Product Safety team type-bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants