Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: Move Confirmation scroll-to-bottom into a React Context #26970

Closed
9 tasks
digiwand opened this issue Sep 6, 2024 · 1 comment · Fixed by #27064
Closed
9 tasks

[Refactor]: Move Confirmation scroll-to-bottom into a React Context #26970

digiwand opened this issue Sep 6, 2024 · 1 comment · Fixed by #27064
Assignees
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team type-enhancement

Comments

@digiwand
Copy link
Contributor

digiwand commented Sep 6, 2024

What is this about?

Currently, the ScrollToBottom component utilizes the useScrollToBottom hook and sets state on the confirm state to pass to the confirm footer.

Task:

  • Move ScrollToBottom logic into a React context
  • Use state from context, instead of confirm state, to enable/disable the confirm footer button

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on issue. Adding release label release-12.5.0 on issue, as issue is linked to PR #27064 which has this release label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team type-enhancement
Projects
None yet
3 participants