[Bug]: RPC - MM breaks with error Message: Cannot read properties of undefined (reading 'rpcPrefs')
#25887
Labels
regression-beta-12.0.0
Regression bug that was found in beta in release 12.0.0
release-12.3.0
Issue or pull request that will be included in release 12.3.0
release-blocker
This bug is blocking the next release
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-wallet-ux
type-bug
Comments
seaona
added
type-bug
Sev2-normal
danjm
added
regression-beta-12.0.0
|
@seaona I am testing on the beta build. But I couldn't replicate this one. It seems to work fine for me. Can you check which Dapps were you connected to? |
|
After investigating a bit further, looks like this only happens if you have the
|
7 tasks
NidhiKJha
added a commit
that referenced
this issue
Jul 19, 2024
If Experimental settings `Select Networks for each site` is off, the domains are undefined. In this case, the fallback network should be the current network. ## **Related issues** Fixes: [#25887](#25887) ## **Manual testing steps** 1. Connect MetaMask to Dapp 2. Go to Permissions, check the logo of network is specific to connected network 3. Turn the experimental setting off, Go back to all permissions page. Now the network logo should be same as globally selected network for all the dapps ## **Screenshots/Recordings** ### **Before**  ### **After** https://github.com/user-attachments/assets/fe0bed9e-c050-4ab8-8607-bf933e1eac63 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-12.3.0
NidhiKJha
added a commit
that referenced
this issue
Jul 19, 2024
If Experimental settings `Select Networks for each site` is off, the domains are undefined. In this case, the fallback network should be the current network. ## **Related issues** Fixes: [#25887](#25887) ## **Manual testing steps** 1. Connect MetaMask to Dapp 2. Go to Permissions, check the logo of network is specific to connected network 3. Turn the experimental setting off, Go back to all permissions page. Now the network logo should be same as globally selected network for all the dapps ## **Screenshots/Recordings** ### **Before**  ### **After** https://github.com/user-attachments/assets/fe0bed9e-c050-4ab8-8607-bf933e1eac63 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
NidhiKJha
added a commit
that referenced
this issue
Jul 19, 2024
If Experimental settings `Select Networks for each site` is off, the domains are undefined. In this case, the fallback network should be the current network. ## **Related issues** Fixes: [#25887](#25887) ## **Manual testing steps** 1. Connect MetaMask to Dapp 2. Go to Permissions, check the logo of network is specific to connected network 3. Turn the experimental setting off, Go back to all permissions page. Now the network logo should be same as globally selected network for all the dapps ## **Screenshots/Recordings** ### **Before**  ### **After** https://github.com/user-attachments/assets/fe0bed9e-c050-4ab8-8607-bf933e1eac63 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
14 tasks
NidhiKJha
added a commit
that referenced
this issue
Jul 22, 2024
If Experimental settings `Select Networks for each site` is off, the domains are undefined. In this case, the fallback network should be the current network. ## **Related issues** Fixes: [#25887](#25887) ## **Manual testing steps** 1. Connect MetaMask to Dapp 2. Go to Permissions, check the logo of network is specific to connected network 3. Turn the experimental setting off, Go back to all permissions page. Now the network logo should be same as globally selected network for all the dapps ## **Screenshots/Recordings** ### **Before**  ### **After** https://github.com/user-attachments/assets/fe0bed9e-c050-4ab8-8607-bf933e1eac63 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/25970?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/25970?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Whenever I click on the
All Permissionsoption from the accounts menu, MetaMask breaks with the errorMessage: Cannot read properties of undefined (reading 'rpcPrefs')Expected behavior
No response
Screenshots/Recordings
rpc-prefs.mp4
Steps to reproduce
Select Networks for each sitetoggle --> this is what makes it fail. If you have it enabled. the Permissions workError messages or log output
No response
Detection stage
In production (default)
Version
12.0.0 beta build
Build type
None
Browser
Chrome
Operating system
Linux
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: