Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unexpected popup behavior when interacting with dapps #25393

Closed
sleepytanya opened this issue Jun 18, 2024 · 4 comments
Closed

[Bug]: Unexpected popup behavior when interacting with dapps #25393

sleepytanya opened this issue Jun 18, 2024 · 4 comments
Labels
Sev3-low Low severity; minimal to no impact upon users stale issues and PRs marked as stale team-confirmations Push issues to confirmations team type-bug

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Jun 18, 2024

Describe the bug

Popup functionality seems working not as expected.

Scenarios:

  1. Have unapproved transaction

  2. Request to switch network - number on the MM icon will increase +1

  3. Popup appears but you can't see the network request, only the unapproved transaction

  4. If you access the popup manually it will show the unapproved transaction

  5. After unapproved transactions rejected, network request can be seen

  6. If you go to the MM home page and reject unapproved tx from there the network request will be shown in full screen mode

  7. Switch network, do not approve

  8. Go to another dapp

  9. Start transaction

  10. MM icon number will increase +1

  11. Popup appears but shows only network request

  12. If you access the popup manually it will show the unapproved transaction request

  13. After unapproved transactions rejected, network request can be seen

  14. If you go to the MM home page and reject unapproved tx from there the network request will be shown in full screen mode

Related issues:

#25361

#25397

Slack discussion links:

https://consensys.slack.com/archives/C03ETQA9EPK/p1695933147044299

https://consensys.slack.com/archives/C03ETQA9EPK/p1695932531166009

Expected behavior

Screenshots/Recordings

popup.mov
Screen.Recording.2024-06-17.at.15.34.40.mov
Screenshot 2024-06-17 at 15 04 58

Steps to reproduce

In the description^^

Error messages or log output

No response

Version

11.16.11

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@hesterbruikman
Copy link

@bschorchit it looks like this issue might describes expected behavior around confirmations sequencing that is not obvious from the UI. Knowing the evolution of confirmation designs, can you take a look please and share if you see it likely this issue can be addressed with a UI improvement? cc @sleepytanya

@bschorchit
Copy link

I've assigned this to confirmations @hesterbruikman

@bschorchit bschorchit added the Sev3-low Low severity; minimal to no impact upon users label Jun 20, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Sep 18, 2024
Copy link
Contributor

github-actions bot commented Nov 2, 2024

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Nov 2, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev3-low Low severity; minimal to no impact upon users stale issues and PRs marked as stale team-confirmations Push issues to confirmations team type-bug
Projects
Archived in project
Development

No branches or pull requests

3 participants