Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Token icons are not displayed on send flow #25189

Closed
sleepytanya opened this issue Jun 10, 2024 · 7 comments · Fixed by #25470
Closed

[Bug]: Token icons are not displayed on send flow #25189

sleepytanya opened this issue Jun 10, 2024 · 7 comments · Fixed by #25470
Labels
regression-RC-12.0.0 release-12.0.0 Issue or pull request that will be included in release 12.0.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 release-blocker This bug is blocking the next release Sev2-normal Normal severity; minor loss of service or inconvenience. team-assets type-bug

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Jun 10, 2024 •
edited by bschorchit
Loading

Describe the bug

All chain icons other than Ethereum mainnet are not displayed on confirmation screen. For Arbitrum, Linea mainnet, Base, zkSync Era icons also not displayed for the currencies on the asset selection screen:

Related issue: #24450

Expected behavior

All chain / token icons are accurately shown.

Screenshots/Recordings

Screenshot 2024-06-10 at 16 59 37

Steps to reproduce

  1. Switch to any network other than mainnet, e.g. Base
  2. Start send+swap / legacy / EIP 1559 etc. transaction
  3. Notice that chain icon is not shown on the confirmation screen

Error messages or log output

No response

Version

12.0.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@sleepytanya sleepytanya added type-bug regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead team-confirmations Push issues to confirmations team regression-RC-12.0.0 labels Jun 10, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jun 10, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jun 10, 2024
@sleepytanya sleepytanya removed the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label Jun 10, 2024
@SayaGT SayaGT added the area-design Design bug (previously known as papercuts - ask Hilary for more detail) label Jun 11, 2024
@desi desi added the Sev3-low Low severity; minimal to no impact upon users label Jun 13, 2024
@hesterbruikman hesterbruikman added team-assets Sev2-normal Normal severity; minor loss of service or inconvenience. and removed area-design Design bug (previously known as papercuts - ask Hilary for more detail) Sev3-low Low severity; minimal to no impact upon users labels Jun 20, 2024
@bschorchit bschorchit added regression-RC-12.0.0 and removed regression-RC-12.0.0 team-confirmations Push issues to confirmations team labels Jun 20, 2024
@bschorchit
Copy link

bschorchit commented Jun 20, 2024 •
edited
Loading

Removing confirmations as the confirmations piece is not a regression on the release. I'm moved the confirmations scope to this new issue: #25447

@bschorchit bschorchit changed the title [Bug]: Chain icons are not displayed on confirmation screen [Bug]: Chain icons are not displayed on send flow Jun 20, 2024
@bschorchit bschorchit changed the title [Bug]: Chain icons are not displayed on send flow [Bug]: Token icons are not displayed on send flow Jun 20, 2024
darkwing added a commit that referenced this issue Jun 21, 2024
@darkwing
fix: #25189 - Display network badge for send flow asset
1852719
@darkwing darkwing mentioned this issue Jun 21, 2024
Merged
7 tasks
@danjm danjm added the release-blocker This bug is blocking the next release label Jun 24, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jun 24, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jun 24, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 24, 2024
@chloeYue chloeYue reopened this Jul 5, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by team Jul 5, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by severity Jul 5, 2024
@chloeYue
Copy link
Contributor

chloeYue commented Jul 5, 2024 •
edited
Loading

Reopen this ticket because I can still reproduce the issue on the latest v12.0.0. Checking with wallet UX team to see if the fix has been cherry-picked into the release branch.

darkwing added a commit that referenced this issue Jul 5, 2024
@darkwing
fix: #25189 - Display network badge for send flow asset (#25470)
dd4c673 
## **Description**

Adds the network badge for the chosen asset in the new Send flow

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25470?quickstart=1)

## **Related issues**

Fixes: #25189

## **Manual testing steps**

1. Go to Ethereum Mainnet
2. Go to the Send flow
3. See the chosen asset with Mainnet logo
4. Change to Base network
5. Go to Send flow
6. See the chosen asset with the Base logo

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img width="409" alt="338344947-c9a6eff0-74f1-4b8a-bca4-48a8325a14d8"
src="https://github.com/MetaMask/metamask-extension/assets/46655/856305e3-5858-4d26-9280-7b539250de6e">



### **After**

<img width="421" alt="SCR-20240621-jquj"
src="https://github.com/MetaMask/metamask-extension/assets/46655/446dc321-5f62-4287-8ab7-5d2ac0eecbd6">




## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@darkwing darkwing mentioned this issue Jul 5, 2024
Merged
14 tasks
@sleepytanya
Copy link
Contributor Author

sleepytanya commented Jul 7, 2024 •
edited
Loading

@chloeYue Fixed on develop:

Screenshot 2024-07-07 at 15 33 34

danjm pushed a commit that referenced this issue Jul 9, 2024
@darkwing
fix (cherry-pick): #25189 - Display network badge for send flow asset (…
09136cd 
…#25470) (#25707)

## **Description**

Adds the network badge for the chosen asset in the new Send flow

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25470?quickstart=1)

## **Related issues**

Fixes: #25189

## **Manual testing steps**

1. Go to Ethereum Mainnet
2. Go to the Send flow
3. See the chosen asset with Mainnet logo
4. Change to Base network
5. Go to Send flow
6. See the chosen asset with the Base logo

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img width="409" alt="338344947-c9a6eff0-74f1-4b8a-bca4-48a8325a14d8"
src="https://github.com/MetaMask/metamask-extension/assets/46655/856305e3-5858-4d26-9280-7b539250de6e">



### **After**

<img width="421" alt="SCR-20240621-jquj"

src="https://github.com/MetaMask/metamask-extension/assets/46655/446dc321-5f62-4287-8ab7-5d2ac0eecbd6">




## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25707?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jul 9, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.0.0 on issue. Adding release label release-12.0.0 on issue, as issue is linked to PR #25470 which has this release label.

@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.0.0 on PR, as PR was cherry-picked in branch 12.0.0.

1 similar comment
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.0.0 on PR, as PR was cherry-picked in branch 12.0.0.

@danjm
Copy link
Contributor

danjm commented Jul 9, 2024

closed by 09136cd

@danjm danjm closed this as completed Jul 9, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jul 9, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-RC-12.0.0 release-12.0.0 Issue or pull request that will be included in release 12.0.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 release-blocker This bug is blocking the next release Sev2-normal Normal severity; minor loss of service or inconvenience. team-assets type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #25189 - Display network badge for send flow asset MetaMask/metamask-extension
8 participants
@desi @danjm @bschorchit @hesterbruikman @metamaskbot @SayaGT @sleepytanya @chloeYue